coldfusionJedi

This entry was posted on Monday, February 7, 2005 at 10:10 AM. It was filed in the following categories: ColdFusion. It has been viewed 8,292 times and has 34 comments.

TweetBacks

Comments

[Add Comment] [Subscribe to Comments]

• Comment 1 written by Tim on 25 May 2005, at 12:27 PM

  

  I posted this in the Macr forums, but no response. When I add this code to my onError function, I now get an error saying rootCause is not defined in the exception argument. When I dump the exception argument, all I see is a TagContext. So I still get all the errors from CFLOCATION tags.
  
  Any ideas?

• Comment 2 written by Raymond Camden on 25 May 2005, at 2:41 PM

  

  You should probably check to see if rootcause exists in the exception struct.
  
  So,
  
  cfif structkeyexists(arguments.exception,"rootCause") and .....

• Comment 3 written by Tim on 25 May 2005, at 3:02 PM

  

  Yes, I do that--which is great but it still doesnt help with the cflocation auto-triggering the onError function. All my cflocation tags trigger this, and the fix for the rootCause checking doesnt help me. Any pointers?

• Comment 4 written by Raymond Camden on 25 May 2005, at 3:05 PM

  

  odd - I don't seem to remember seeing cflocation triggering onerror. You sure you aren't using a beta?
  
  Anyway - why not simply cfdump the exception and see if it is obvious what the exception is.

• Comment 5 written by Tim on 25 May 2005, at 4:08 PM

  

  Your blog entry even says cflocation will trigger the error--and it does indeed.
  
  I am running a full version of MX7 with the second hotfix.
  
  I added a CFDUMP of the exception structure in my onError tag. Turns out in your blog you say to use rootCause, but that doesnt exist. What does exist is "Type". So the example code in your entry should be this:
  
  <cfif StructKeyExists(arguments.exception,"type") and arguments.exception.type eq "coldfusion.runtime.AbortException">
     <cfreturn/>
  </cfif>
  
  Thanks for helping me lead to the right answer.

• Comment 6 written by Raymond Camden on 25 May 2005, at 4:48 PM

  

  Yes, you are right - sorry for that. I'll try to update the entry a bit later today!

• Comment 7 written by John on 25 May 2005, at 7:31 PM

  

  Tim,
  When I try the code you just posted I receive this error:
  Element EXCEPTION is undefined in ARGUMENTS
  I assume you are not receiving this error message, so I wonder what I could be doing wrong.

• Comment 8 written by Tim on 26 May 2005, at 12:36 AM

  

  Here is the whole content of my onError function:
  
  <cffunction name="onError">
  <cfargument name="Exception" required=true/>
  <cfargument type="String" name="EventName" required=true/>
  
  <cfif StructKeyExists(arguments.exception,"type") and arguments.exception.type eq "coldfusion.runtime.AbortException">
  <cfreturn/>
  </cfif>
  ... code to display error message to user...
  
  </cffunction>

• Comment 9 written by Justice on 24 October 2005, at 6:47 AM

  

  You guys are my hero. I am completely embracing the new application.cfc method. My only other beef so far is that, when I was using the 'cflogin' method of maintaining authentication, code that I put in 'onSessionEnd' would never properly execute a 'cflogout'. I ended up maintaining user log-in state in an application.array and simply removing them onSessionEnd. Otherwise, my users would always get 'you are already logged in' every time they walked away and came back to their desks after the session timeout. Oh well, there are too many advantages to using the application.cfc to quibble over small stuff.
  
  Quick question: Does anyone else here include template-style code in the onRequest block? I have a cfinclude of all header style code right before my cfinclude of #argument.thePage#.

• Comment 10 written by Raymond Camden on 24 October 2005, at 7:59 AM

  

  Justice - If you have tied your security to session with loginstore=session, then this makes sense. In onSessionEnd, the session is already dead, therefore cflogout has no purpose. You can just ignore it. Just noticed you said they get 'already logged in' messages. Try adding loginstorage="session" (in the This scope, like other settings) and see if that helps.
  
  I do NOT do layout in onRequest.

• Comment 11 written by Justice on 24 October 2005, at 8:04 AM

  

  Well, for whatever reason (even tho I have loginstorage set to session) I would still have to re-start the server to allow a user to log back in. I must have something mucked up somewhere =)
  
  Is there a reason you do not do any other code in onRequest? ie, I have an include that just has my CSS links, and 2 javascript references in it. What would be the difference in putting this in an include on each page? I used to do this in my application.cfm file. Where should it go when using application.cfc?

• Comment 12 written by Raymond Camden on 24 October 2005, at 8:06 AM

  

  I'll double check the session/onsessionend/cflogon thing today, cuz that definitely sounds wrong.
  
  I rarely use onRequest since it impacts web services and flash remoting. That being said, I do layout in a custom tag. If you did it in onRequest, it would mean EVERY page would you use the layout, which would be a problem if your site had popups, or if you wanted something different before a person was logged in.

• Comment 13 written by Derek on 16 April 2006, at 11:50 PM

  

  This code I inherited uses onRequest. I want to use AJAX and this is preventing it. I tried the sep app.cfc trick, but no go, or I am doing it wrong. the whole app.cfc is new to me.
  So how do I remove this w/o errors?
  
     <cffunction name="onRequest" returnType="void">
         <cfargument name="thePage" type="string" required="true">
         <cfinclude template="#arguments.thePage#">
     </cffunction>

• Comment 14 written by Raymond Camden on 17 April 2006, at 8:08 AM

  

  Just remove it. Your onRequest is doing nothing (technically it is doing something, but functionally it is not), so just remove that onRequest method and see if it helps.

• Comment 15 written by Derek on 17 April 2006, at 9:06 AM

  

  I tried that, but get an error that it can't find a UDF.

• Comment 16 written by Raymond Camden on 17 April 2006, at 9:20 AM

  

  If your page is trying to load a UDF, then you need to cfinclude it. One thing people use onRequest for is to load UDFs into the variables scope. Perhaps your onRequest had it? The one you had pasted did NOT do that.

• Comment 17 written by Derek on 17 April 2006, at 9:37 AM

  

  The udfs are getting loaded on the onRequestStart
  
     <cffunction name="onRequestStart" returnType="boolean" output="false">
         <cfargument name="thePage" type="string" required="true">
            <cfscript>
              if(NOT IsDefined("Application.Init") OR IsDefined("URL.ReInit")){
              // init the bookiecharts cfc
              Temp = createObject("component","bookiecharts.cfcs.settings").InitApplication();
              //Set Global Init app flag var to true
              Application.Init = true;
              }
           </cfscript>
           
           <!--- Call the FormURL2Attributes tag --->
           <cfmodule template="/#Application.Settings.RootMapping#/customtags/FormURL2Attributes.cfm">      
           <cfinclude template="/#Application.Settings.RootMapping#/udfs/udfs.cfm">
           <cfsetting showdebugoutput="yes">
         <cfreturn true>
     </cffunction>

• Comment 18 written by Raymond Camden on 17 April 2006, at 9:50 AM

  

  I'm not sure what to tell you then. Commenting out the onRequest should not have c... ohhh. Ok, so if I remember right, the presense of onRequest has the side effect of copying the variables from the CFC to your page's Variables scope.
  
  THe problem you have is that onRequestStart is using it's OWN variables scope now. So your page doesn't have access to the UDFs. What you need to do, or what you CAN do I should say, is consider simply copying the UDFs to the request scope. Then you change any call like so, result = someUDF(), to: result = request.udfs.someUDF().

• Comment 19 written by Derek on 17 April 2006, at 10:09 AM

  

  cool, that worked. Now to tackle my ajax.cfc issue. :(

• Comment 20 written by Ben Nadel on 21 April 2006, at 8:02 AM

  

  Thanks Ray, that just helped me after 30 minutes of beating my head against the wall :)

• Comment 21 written by Stefan on 29 December 2006, at 5:37 PM

  

  Example in blog is still incorrect. Examples for onError seems to be incorrect everywhere, including on the LiveDocs. Where do this 'rootCause' come from? An early beta? It does not exist in my exceptions anyway, that's for sure.
  
  Happy new year,

• Comment 22 written by Raymond Camden on 29 December 2006, at 5:47 PM

  

  It does exist - just not always. The code should be updated to _first_ check for the existence, and THEN check the value.

• Comment 23 written by Stefan on 29 December 2006, at 7:40 PM

  

  Ok, found it... but in my tests rootCause contains the original error struct, like arguments.exception.rootCause.type etc and therefore you would also need to check if arguments.exception.rootCause is a simple value?
  Actually, I can not get a onError triggered by cflocation at all. I tried:
  <cffunction name="onError" returnType="void">
  <cfargument name="Exception" required=true/>
  <cfargument name="EventName" type="String" required=true/>
  <cflog text="onError triggered" file="RedirLog">
  </cffunction>
  But it does not react at all on my cflocations. Any tip of how I should detect cflocation?

• Comment 24 written by Raymond Camden on 30 December 2006, at 1:21 PM

  

  To be honest, I seem to remember issues with cflocation AND cfabort, and the behavior changing from 7 to 7.0.2. It may even be totally fixed in 7.0.2 which may explain why you can't reproduce it. One quick tip - you can always wrap a cfdump of the arguments in onerror inside a cfsavecontent and save the result to a file. Or cfdump the arguments and then cfabort.

• Comment 25 written by sinuy on 8 May 2007, at 4:01 AM

  

  hi guys
  i previously use cferror on Application.cfc/cfm. i found tat the '#ERROR.Diagnostics#' able to tells exactly which line of my code occurred.
  
  does onError function has this feature as well? and how?

• Comment 26 written by Raymond Camden on 8 May 2007, at 7:11 AM

  

  What you get in onError is the same as cferror. Actually a bit more as if the error occurs in another method of the app.cfc file, you get that info as well.

• Comment 27 written by Rony Fayyad on 4 June 2007, at 10:41 PM

  

  Hi All,
  
  I have some code in the onrequeststart() function which checks to see if a user is logged in, in order to access certain admin pages.
  
  Now if they are not logged in, it would move them to the login page.
  
  Here is a snippet of the code found in the onrequeststart function.
  
  <cfheader statuscode="301" statustext="Moved Permanently">
  
  <cfheader name="Admin login" value="localhost/admin/index.cfm">
  <cfabort>
  
  However, the move never happens.
  
  It goes to the onerror() ( i added the code from this blog) and all it does now is show an empty page.
  
  Any help here guys?

• Comment 28 written by Raymond Camden on 5 June 2007, at 8:30 AM

  

  Add a dump in onError and see what it is. Oh - it also may be abort. CFABORT will run onError. You can add a check in OnError to see if it was cfabort, and if so, ignore it.
  
  <cfif arguments.exception.rootcause.type is "coldfusion.runtime.AbortException">
     <cfreturn>
  </cfif>

• Comment 29 written by Jim on 16 July 2007, at 10:42 AM

  

  For googlers like me looking for answers...
  
  Just wanted to pass along the combination of the two methods used in this thread for trapping the cfabort/cflocation on error bug. netheir one of the methods worked completely for me but when I combined both all is well.
  
  <cfif isDefined("arguments.exception.Type") and (arguments.exception.Type eq "coldfusion.runtime.AbortException")>
           <cfreturn/>
        <cfelseif isDefined("arguments.exception.Type") and (arguments.exception.Type eq "Expression")>
           <cfif isDefined("arguments.exception.RootCause.Type") and arguments.exception.RootCause.Type eq "coldfusion.runtime.AbortException">
              <cfreturn/>
           </cfif>
        </cfif>

• Comment 30 written by Raymond Camden on 16 July 2007, at 10:47 AM

  

  Thanks Jim.

• Comment 31 written by Craig Benner on 11 March 2009, at 11:36 AM

  

  I noticed this is an old blog, but i thought i would post that I have another work around to the onRequest issue. I have blogged about it here. http://www.personal.psu.edu/cpb113/blogs/vantage_v...
  
  It basically shows how the code needs to invoke the method requested when ajax/webservices are being called.

• Comment 32 written by JP on 17 July 2009, at 4:08 PM

  

  Just wanted to say we are still on CF7 (yup) and we had this prob too. Your solution works great.

• Comment 33 written by Jody Fitzpatrick on 27 November 2009, at 7:55 AM

  

  Is this fixed in CF8? -- or does this bug still persist?

• Comment 34 written by Raymond Camden on 27 November 2009, at 8:00 AM

  

  onError was fixed a while ago.
  onRequest blocking flashremoting/CFC calls was fixed in CF9.

[Add Comment] [Subscribe to Comments]